netdev - Re: [PATCH] net: fec: Place 'inline' in the beginning of declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 07 Jan 2013 19:23:41 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	festevam@...il.com
Cc:	shawn.guo@...aro.org, netdev@...r.kernel.org,
	fabio.estevam@...escale.com
Subject: Re: [PATCH] net: fec: Place 'inline' in the beginning of
 declaration

From: Fabio Estevam <festevam@...il.com>
Date: Tue,  8 Jan 2013 01:20:33 -0200

> From: Fabio Estevam <fabio.estevam@...escale.com>
> 
> Fix the following warning when building with W=1 option:
> 
> drivers/net/ethernet/freescale/fec.c:810:1: warning: '__inline__' is not at beginning of declaration [-Wold-style-declaration]
> 
> Putting __inline__ in the beggining then checkpath complains:
> 
> WARNING: plain inline is preferred over __inline__
> #24: FILE: drivers/net/ethernet/freescale/fec.c:810:
> +static __inline__ void fec_get_mac(struct net_device *ndev)
> 
> ,so use 'inline' in the beginning and make gcc and checkpath happy.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

I would remove the inline tag altogether, it's pointless.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html