netdev - RE: [E1000-devel] [PATCH net-next] igbvf: fix setting addr_assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Jan 2013 17:09:55 +0000
From:	"Williams, Mitch A" <mitch.a.williams@...el.com>
To:	Stefan Assmann <sassmann@...nic.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>
Subject: RE: [E1000-devel] [PATCH net-next] igbvf: fix setting
 addr_assign_type	if PF is up

> -----Original Message-----
> From: Stefan Assmann [mailto:sassmann@...nic.de]
> Sent: Wednesday, January 09, 2013 1:59 AM
> To: netdev@...r.kernel.org
> Cc: e1000-devel@...ts.sourceforge.net; sassmann@...nic.de
> Subject: [E1000-devel] [PATCH net-next] igbvf: fix setting
> addr_assign_type if PF is up
> 
> When the PF is up and igbvf is loaded the MAC address is not generated
> using eth_hw_addr_random(). This results in addr_assign_type not to be
> set.
> Make sure it gets set.
> 

NAK - In this case, the address may or may not be random. The user may
have (and should have!) explicitly set this address from the host to
ensure that the VF device receives the same address each time it boots.

-Mitch

> Signed-off-by: Stefan Assmann <sassmann@...nic.de>
> ---
>  drivers/net/ethernet/intel/igbvf/netdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c
> b/drivers/net/ethernet/intel/igbvf/netdev.c
> index 53281ff..6a698c5 100644
> --- a/drivers/net/ethernet/intel/igbvf/netdev.c
> +++ b/drivers/net/ethernet/intel/igbvf/netdev.c
> @@ -2746,6 +2746,7 @@ static int igbvf_probe(struct pci_dev *pdev, const
> struct pci_device_id *ent)
>  			dev_err(&pdev->dev, "Error reading MAC address\n");
>  			goto err_hw_init;
>  		}
> +		netdev->addr_assign_type = NET_ADDR_RANDOM;
>  		memcpy(netdev->dev_addr, adapter->hw.mac.addr,
>  			netdev->addr_len);
>  	}
> --
> 1.8.0.2
> 
> 
> ------------------------------------------------------------------------
> ------
> Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
> and much more. Keep your Java skills current with LearnJavaNow -
> 200+ hours of step-by-step video tutorials by Java experts.
> SALE $49.99 this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122612
> _______________________________________________
> E1000-devel mailing list
> E1000-devel@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/e1000-devel
> To learn more about Intel&#174; Ethernet, visit
> http://communities.intel.com/community/wired
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html