netdev - Re: [PATCH v2] net: set default_ethtool_ops in register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 09 Jan 2013 23:57:38 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sgruszka@...hat.com
Cc:	netdev@...r.kernel.org, edumazet@...gle.com,
	greearb@...delatech.com, bjorn@...k.no,
	linux-wireless@...r.kernel.org, bhutchings@...arflare.com,
	mirqus@...il.com
Subject: Re: [PATCH v2] net: set default_ethtool_ops in register_netdevice

From: Stanislaw Gruszka <sgruszka@...hat.com>
Date: Tue, 8 Jan 2013 16:38:51 +0100

> Since:
> 
> commit 2c60db037034d27f8c636403355d52872da92f81
> Author: Eric Dumazet <edumazet@...gle.com>
> Date:   Sun Sep 16 09:17:26 2012 +0000
> 
>     net: provide a default dev->ethtool_ops
> 
> wireless core does not correctly assign ethtool_ops. In order to fix
> the problem, move assignement of default_ethtool_ops to
> register_netdevice(). This is safe because both register_netdevice()
> and dev_ethtool() are protected by RTNL lock.
> 
> Patch is besed on hint of Micha┅ Miros┅aw.
> 
> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>
> Cc: stable@...r.kernel.org # 3.7+
> ---
> v1 -> v2: change order of default_ethtool_ops initialization to avoid
> the problem. Change the subject accordingly.

I don't understand this.  Why is the assignment of default_ethtool_ops
at netdev allocation time not working?  Is wireless really not using
alloc_netdev*()?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html