netdev - RE: [RFC PATCH] net: phy: remove flags argument from phy_{attach,connect,connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 13 Jan 2013 10:54:12 +0200
From:	Kosta Zertsekel <konszert@...vell.com>
To:	Florian Fainelli <florian@...nwrt.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"afleming@...il.com" <afleming@...il.com>
Subject: RE: [RFC PATCH] net: phy: remove flags argument from
 phy_{attach,connect,connect_direct}

> The flags argument of the phy_{attach,connect,connect_direct} functions is used to assign a struct phy_device dev_flags with the value passed.
> All callers but the tg3 driver pass the flag 0, which results in the underlying PHY drivers in drivers/net/phy/ not being able to actually use any
> of the flags they would check in dev_flags. This patch gets rid of the flags argument, and passes phydev->dev_flags to the internal PHY library call
> phy_attach_direct() such that drivers which actually modify a phy device dev_flags get the value preserved for use by the underly phy driver.

Acked by konszert@...vell.com.

It seems this patch should be reposted on linux-kernel@...r.kernel.org list for wider approval, isn't it?
Anyway, I think it is prudent to abandon my narrow patch that fixed only phy_attach() in mv643xx network driver.

--- KostaZ
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html