lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 12 Jan 2013 22:50:13 -0500 From: Benjamin LaHaise <bcrl@...ck.org> To: Eric Dumazet <eric.dumazet@...il.com> Cc: David Miller <davem@...emloft.net>, socketcan@...tkopp.net, netdev@...r.kernel.org Subject: Re: [PATCH net-next] pkt_sched: namespace aware ifb On Sat, Jan 12, 2013 at 07:06:14PM -0800, Eric Dumazet wrote: > From: Eric Dumazet <edumazet@...gle.com> > > act_mirred needs to find the current net_ns, and struct net > pointer is not provided in the call chain. We run in process > context and current->nsproxy->net_ns is the needed pointer. ... I don't think this is correct. Going by the call chain, tcf_action_add can be called because of a netlink message, and that netlink message may not be in the same "struct net" as the current process. It looks like the ->init operation is going to need to have the namespace passed in for this to work correctly. -ben > diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c > index 9c0fd0c..f5a7e18 100644 > --- a/net/sched/act_mirred.c > +++ b/net/sched/act_mirred.c > @@ -88,7 +88,7 @@ static int tcf_mirred_init(struct nlattr *nla, struct nlattr *est, > return -EINVAL; > } > if (parm->ifindex) { > - dev = __dev_get_by_index(&init_net, parm->ifindex); > + dev = __dev_get_by_index(current->nsproxy->net_ns, parm->ifindex); > if (dev == NULL) > return -ENODEV; > switch (dev->type) { > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- "Thought is the essence of where you are now." -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists