netdev - Re: [PATCH 15/15] batman-adv: unbloat batadv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 Jan 2013 18:53:13 +1000
From:	Antonio Quartulli <ordex@...istici.org>
To:	Joe Perches <joe@...ches.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	b.a.t.m.a.n@...ts.open-mesh.org,
	Marek Lindner <lindner_marek@...oo.de>
Subject: Re: [PATCH 15/15] batman-adv: unbloat batadv_priv if debug is not
 enabled

Hi Joe,

On Mon, Jan 14, 2013 at 09:36:40 -0800, Joe Perches wrote:
> On Mon, 2013-01-14 at 09:41 +1000, Antonio Quartulli wrote:
> > diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h
> []
> > @@ -284,12 +284,16 @@ struct batadv_priv {
> >  	atomic_t gw_bandwidth;		/* gw bandwidth */
> >  	atomic_t orig_interval;		/* uint */
> >  	atomic_t hop_penalty;		/* uint */
> > +#ifdef CONFIG_BATMAN_ADV_DEBUG
> >  	atomic_t log_level;		/* uint */
> > +#endif
> >  	atomic_t bcast_seqno;
> >  	atomic_t bcast_queue_left;
> >  	atomic_t batman_queue_left;
> >  	char num_ifaces;
> > +#ifdef CONFIG_BATMAN_ADV_DEBUG
> >  	struct batadv_debug_log *debug_log;
> > +#endif
> >  	struct kobject *mesh_obj;
> >  	struct dentry *debug_dir;
> >  	struct hlist_head forw_bat_list;
> 
> How about moving one of these so
> there's only one #ifdef block.

Yeah. This is the main struct and actually it still needs some more housekeeping
(and some love).
It was initially sorted in another way, but as soon as we added new features it
lost its shape.

We will take care of that.

Thanks a lot!
Cheers,


-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

Content of type "application/pgp-signature" skipped