lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Jan 2013 14:32:31 -0700 From: Jean Sacren <sakiwit@...il.com> To: David Miller <davem@...emloft.net> Cc: sakiwit@...il.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next] ipip: do not use 'err' variable for setting return value From: David Miller <davem@...emloft.net> Date: Tue, 15 Jan 2013 03:20:08 -0500 > > From: Jean Sacren <sakiwit@...il.com> > Date: Tue, 15 Jan 2013 01:14:10 -0700 > > > It's a bit confusing to set 'err' variable inside and outside of the > > block for the return value of ipip_err(). We don't even need this > > variable, so clean it all up to spare declaration as well as bunch of > > unnecessary initializations and jumps. > > > > Signed-off-by: Jean Sacren <sakiwit@...il.com> > > It makes the non-error path straight line code. I thought about the error path, but I realized the error handling code couldn't be simpler. There is only one error, namely ENOENT, which warrants no error path. As 'err' variable was used, you were forced to reset it to zero seven months ago. Again you were forced to reset it to zero six months ago. As you were doubly forced, finally I came up with this idea of getting rid of the unnecessary variable. Also the error handling in the patch is consistent with the way earlier portion of the function definition does. > The code as-is is fine, and I'm not applying this patch, sorry. Thank you for reviewing. This is a rather trivial patch. If patches like this one are not compelling enough for acceptance, that's fair enough. -- Jean Sacren -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists