netdev - Re: [RFC(v2) net-next 01/13] ndisc: Refer/Update neigh->updated with write lock.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Jan 2013 14:35:40 +0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
CC:	netdev@...r.kernel.org
Subject: Re: [RFC(v2) net-next 01/13] ndisc: Refer/Update neigh->updated with
 write lock.

On 01/16/2013 12:44 AM, YOSHIFUJI Hideaki wrote:
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
> ---
>   net/ipv6/route.c |   12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 7c34c01..1341f68 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -499,22 +499,26 @@ static void rt6_probe(struct rt6_info *rt)
>   	 * to no more than one per minute.
>   	 */
>   	neigh = rt ? rt->n : NULL;
> -	if (!neigh || (neigh->nud_state & NUD_VALID))
> +	if (!neigh)
> +		return;
> +	write_lock_bh(&neigh->lock);
> +	if (neigh->nud_state & NUD_VALID) {
> +		write_unlock_bh(&neigh->lock);
>   		return;
> -	read_lock_bh(&neigh->lock);
> +	}
>   	if (!(neigh->nud_state & NUD_VALID) &&
>   	    time_after(jiffies, neigh->updated + rt->rt6i_idev->cnf.rtr_probe_interval)) {
>   		struct in6_addr mcaddr;
>   		struct in6_addr *target;
>   
>   		neigh->updated = jiffies;
> -		read_unlock_bh(&neigh->lock);
> +		write_unlock_bh(&neigh->lock);

This looks like a bug fix, which deserves a separated patch rather than
in this rt->n removal series.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html