netdev - Re: [PATCH v3] net, wireless: overwrite default_ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Jan 2013 12:52:43 -0800
From:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
To:	Stanislaw Gruszka <sgruszka@...hat.com>
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org,
	edumazet@...gle.com, greearb@...delatech.com, bjorn@...k.no,
	linux-wireless@...r.kernel.org, mirqus@...il.com,
	johannes@...solutions.net, David Miller <davem@...emloft.net>
Subject: Re: [PATCH v3] net, wireless: overwrite default_ethtool_ops

On Fri, Jan 11, 2013 at 3:59 PM, David Miller <davem@...emloft.net> wrote:
> From: Ben Hutchings <bhutchings@...arflare.com>
> Date: Fri, 11 Jan 2013 20:00:32 +0000
>
>> On Fri, 2013-01-11 at 10:19 +0100, Stanislaw Gruszka wrote:
>>> Since:
>>>
>>> commit 2c60db037034d27f8c636403355d52872da92f81
>>> Author: Eric Dumazet <edumazet@...gle.com>
>>> Date:   Sun Sep 16 09:17:26 2012 +0000
>>>
>>>     net: provide a default dev->ethtool_ops
>>>
>>> wireless core does not correctly assign ethtool_ops.
>>>
>>> After alloc_netdev*() call, some cfg80211 drivers provide they own
>>> ethtool_ops, but some do not. For them, wireless core provide generic
>>> cfg80211_ethtool_ops, which is assigned in NETDEV_REGISTER notify call:
>>>
>>>         if (!dev->ethtool_ops)
>>>                 dev->ethtool_ops = &cfg80211_ethtool_ops;
>>>
>>> But after Eric's commit, dev->ethtool_ops is no longer NULL (on cfg80211
>>> drivers without custom ethtool_ops), but points to &default_ethtool_ops.
>>>
>>> In order to fix the problem, provide function which will overwrite
>>> default_ethtool_ops and use it by wireless core.
>>>
>>> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>
>> [...]
>>
>> Acked-by: Ben Hutchings <bhutchings@...arflare.com>
>
> Applied.

Stanislaw, I see Eric's patch went in on v3.7-rc1 as such I suspect
this needs to be submitted as a stable fix for v3.7.5. Its already on
v3.8-rc4.

mcgrof@...jol ~/linux-stable (git::linux-3.7.y)$ git describe
--contains 2c60db037034d27f8c636403355d52872da92f81
v3.7-rc1~145^2~142

  Luis
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html