netdev - Re: [PATCH] net: ks8851: convert to threaded IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Jan 2013 20:33:51 -0800
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	balbi@...com, sboyd@...eaurora.org, mjr@...wisc.edu,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: ks8851: convert to threaded IRQ

On Mon, 2013-01-28 at 22:31 -0500, David Miller wrote:
> From: Felipe Balbi <balbi@...com>
> Date: Wed, 23 Jan 2013 15:51:38 +0200
[]
> > @@ -1505,7 +1485,8 @@ static int ks8851_probe(struct spi_device *spi)
[]
> > -     ret = request_irq(spi->irq, ks8851_irq, IRQF_TRIGGER_LOW,
> > +     ret = request_threaded_irq(spi->irq, NULL, ks8851_irq,
> > +                     IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> >                         ndev->name, ks);
> 
> You need to indent the second and third line of this function call
> properly.  It should be:
> 
>         ret = function_call(arg1, arg2,
>                             arg3, arg4,
>                             arg5, arg6, etc.);

Instead of writing all these emails all the time,
maybe it'd be better to make the checkpatch messages
that are currently emitted only with the --strict
option (like parenthesis alignment) emitted whenever
working on files in drivers/net/ and net/.
---
 scripts/checkpatch.pl | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9cec6dd..da1d15a 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -35,6 +35,8 @@ my $help = 0;
 my $configuration_file = ".checkpatch.conf";
 my $max_line_length = 80;
 
+my $realfile = '';
+
 sub help {
 	my ($exitcode) = @_;
 
@@ -1287,7 +1289,9 @@ sub WARN {
 	}
 }
 sub CHK {
-	if ($check && report("CHECK", $_[0], $_[1])) {
+	if ($realfile =~ m@^(drivers/net|net/)@) {
+		WARN($_[0], $_[1]);
+	} elsif ($check && report("CHECK", $_[0], $_[1])) {
 		our $clean = 0;
 		our $cnt_chk++;
 	}
@@ -1381,7 +1385,7 @@ sub process {
 	our $cnt_chk = 0;
 
 	# Trace the real file/line as we go.
-	my $realfile = '';
+	$realfile = '';
 	my $realline = 0;
 	my $realcnt = 0;
 	my $here = '';



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html