netdev - Re: [PATCH net-next 11/11] net/mlx4_en: Fix transmit timeout when driver restarts port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Jan 2013 16:50:12 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Amir Vadai <amirv@...lanox.com>
CC:	"David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
	Eugenia Emantayev <eugenia@...lanox.com>
Subject: Re: [PATCH net-next 11/11] net/mlx4_en: Fix transmit timeout when
 driver restarts port

On Wed, 2013-01-30 at 12:34 +0200, Amir Vadai wrote:
> Under heavy CPU load, changing, ring size/mtu/etc. could result in transmit
> timeout, since stop-start port might take more than 10 seconds.
> Calling netif_detach_device to prevent tx queue transmit timeout.
[...]

It's actually worse than that - the watchdog can fire instantly if it
has been 10 seconds since the last packet was queued.

Anyway, this looks very much like a pending fix for the same issue in
sfc, so hopefully we both did it right. :-)

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html