netdev - Re: [PATCH net-next] igb: increase timeout for ethtool offline self-test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 01 Feb 2013 16:29:03 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Stefan Assmann <sassmann@...nic.de>
Cc:	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net,
	carolyn.wyborny@...el.com
Subject: Re: [PATCH net-next] igb: increase timeout for ethtool offline
 self-test

On Fri, 2013-02-01 at 16:21 +0100, Stefan Assmann wrote:
> On several machines with i350 adapters the ethtool offline self-test
> sometimes
> fails. This happens because link auto negotiation may take longer than
> the
> timeout of 4 seconds. Increasing the timeout by 1 seconds resolves the
> issue.
> 
> Output from a failing i350 offline self-test:
> while [ 1 ]; do ethtool -t eth2 offline; done
> The test result is PASS
> The test extra info:
> Register test  (offline)         0
> Eeprom test    (offline)         0
> Interrupt test (offline)         0
> Loopback test  (offline)         0
> Link test   (on/offline)         0
> 
> The test result is FAIL
> The test extra info:
> Register test  (offline)         0
> Eeprom test    (offline)         0
> Interrupt test (offline)         0
> Loopback test  (offline)         0
> Link test   (on/offline)         1
> 
> The test result is PASS
> The test extra info:
> Register test  (offline)         0
> Eeprom test    (offline)         0
> Interrupt test (offline)         0
> Loopback test  (offline)         0
> Link test   (on/offline)         0
> 
> Signed-off-by: Stefan Assmann <sassmann@...nic.de>
> ---
>  drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-) 

Thanks Stefan, I will add the patch to my queue!

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)