lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 Feb 2013 17:33:11 +0530 From: Sekhar Nori <nsekhar@...com> To: Prabhakar Lad <prabhakar.csengg@...il.com> CC: <linux-arm-kernel@...ts.infradead.org>, <davinci-linux-open-source@...ux.davincidsp.com>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <devicetree-discuss@...ts.ozlabs.org>, Heiko Schocher <hs@...x.de>, "Lad, Prabhakar" <prabhakar.lad@...com> Subject: Re: [PATCH v2 4/6] ARM: davinci: da850: add DT node for eth0. On 1/28/2013 7:17 PM, Prabhakar Lad wrote: > From: Lad, Prabhakar <prabhakar.lad@...com> > > Add eth0 device tree node information and pinmux for mii to da850 by > providing interrupt details and local mac address of eth0. > > Signed-off-by: Lad, Prabhakar <prabhakar.lad@...com> > Cc: linux-arm-kernel@...ts.infradead.org > Cc: linux-kernel@...r.kernel.org > Cc: davinci-linux-open-source@...ux.davincidsp.com > Cc: netdev@...r.kernel.org > Cc: devicetree-discuss@...ts.ozlabs.org > Cc: Sekhar Nori <nsekhar@...com> > Cc: Heiko Schocher <hs@...x.de> > --- > arch/arm/boot/dts/da850-evm.dts | 5 +++++ > arch/arm/boot/dts/da850.dtsi | 35 +++++++++++++++++++++++++++++++++++ > 2 files changed, 40 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts > index a319491..19aa2b3 100644 > --- a/arch/arm/boot/dts/da850-evm.dts > +++ b/arch/arm/boot/dts/da850-evm.dts > @@ -30,6 +30,11 @@ > mdio: davinci_mdio@...4000 { > status = "okay"; > }; > + eth0: emac@...0000 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&mii_pins>; > + }; > }; > nand_cs3@...00000 { > status = "okay"; > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > index ba28f2d..76905f3 100644 > --- a/arch/arm/boot/dts/da850.dtsi > +++ b/arch/arm/boot/dts/da850.dtsi > @@ -56,6 +56,26 @@ > 0x30 0x01100000 0x0ff00000 > >; > }; > + mii_pins: pinmux_mii_pins { > + pinctrl-single,bits = < > + /* > + * MII_TXEN, MII_TXCLK, MII_COL > + * MII_TXD_3, MII_TXD_2, MII_TXD_1 > + * MII_TXD_0 > + */ > + 0x8 0x88888880 0xfffffff0 > + /* > + * MII_RXER, MII_CRS, MII_RXCLK > + * MII_RXDV, MII_RXD_3, MII_RXD_2 > + * MII_RXD_1, MII_RXD_0 > + */ > + 0xc 0x88888888 0xffffffff > + /* MDIO_CLK, MDIO_D */ You call this mii_pins, but include mdio pins in there as well. Can you separate them out? Then some board which uses rmii can simply reuse the entry. > + 0x10 0x00222288 0x00ffffff > + /* GPIO2_6 */ > + 0x18 0x00000080 0x000000f0 This is SoC specific pin list. Such board specific pins should not make it here. > + >; > + }; > }; > serial0: serial@...2000 { > compatible = "ns16550a"; > @@ -88,6 +108,21 @@ > reg = <0x224000 0x1000>; > bus_freq = <2200000>; > }; > + eth0: emac@...0000 { > + compatible = "ti,davinci-dm6467-emac"; > + reg = <0x220000 0x4000>; > + ti,davinci-ctrl-reg-offset = <0x3000>; > + ti,davinci-ctrl-mod-reg-offset = <0x2000>; > + ti,davinci-ctrl-ram-offset = <0>; > + ti,davinci-ctrl-ram-size = <0x2000>; > + local-mac-address = [ 00 00 00 00 00 00 ]; > + interrupts = <33 > + 34 > + 35 > + 36 > + >; > + phy-handle = <&mdio>; I doubt this is required. This property is to pass a handle to the phy, not mdio bus. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists