netdev - Re: [PATCH] net: sh_eth: Add support of device tree probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Feb 2013 17:26:19 +0900
From:	Magnus Damm <magnus.damm@...il.com>
To:	Simon Horman <horms+renesas@...ge.net.au>
Cc:	netdev@...r.kernel.org, linux-sh@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org,
	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
Subject: Re: [PATCH] net: sh_eth: Add support of device tree probe

Hey Simon, Iwamatsu-san,

On Wed, Feb 6, 2013 at 11:00 AM, Simon Horman
<horms+renesas@...ge.net.au> wrote:
> From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
>
> This adds support of device tree probe for Renesas sh-ether driver.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>

Thanks for your work on this

> +++ b/Documentation/devicetree/bindings/net/sh_ether.txt
> @@ -0,0 +1,43 @@
> +* Renesas Electronics SuperH EMAC
> +
> +This file provides information, what the device node
> +for the sh_eth interface contains.
> +
> +Required properties:
> +- compatible:                   "renesas,sh-eth";
> +- interrupt-parent:             The phandle for the interrupt controller that
> +                                services interrupts for this device.
> +- reg:                          Offset and length of the register set for the
> +                                device.
> +- interrupts:                   Interrupt mapping for the sh_eth interrupt
> +                                sources (vector id).
> +- phy-mode:              String, operation mode of the PHY interface.
> +- sh-eth,edmac-endian:          String, endian of sh_eth dmac.
> +- sh-eth,register-type:         String, register type of sh_eth.
> +                                Please select "gigabit", "fast-sh4" or
> +                                "fast-sh3-sh2".
> +                                Please select "little" or "big".
> +- sh-eth,endian:                String, endian of sh_eth dmac.
> +- sh-eth,phy-id:                PHY id.
> +
> +Optional properties:
> +- local-mac-address : 6 bytes, mac address


> +- sh-eth,no-ether-link:         set link control by software. When device does
> +                                not support ether-link, set.
> +- sh-etn,ether-link-active-low: set link check method.
> +                                When detection of link is treated as active-low,
> +                                set.
> +- sh-etn,needs-init:            Initialization flag.
> +                                When initialize device in probing device, set.

I believe there is a spelling mistake here with "sh-etn" instead of "sh-eth".

Also, I am happy when DT is used to describe hardware information, but
in the case of "needs-init" it more looks like software policy.

Thanks,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html