netdev - Null pointers linux3.8-rc6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Feb 2013 20:32:11 +0100
From:	syrine tlili <syrine.tl@...il.com>
To:	netdev@...r.kernel.org
Cc:	Jesper Juhl <jj@...osbits.net>
Subject: Null pointers linux3.8-rc6

Hi:

I would like to report some errors related to the usage of unchecked
null pointers.
I also suggest a set of patches to fix the detected errors.

Syrine

diff --git a/a/arch/x86/platform/efi/efi.c b/b/arch/x86/platform/efi/efi.c
index 77cf009..e64c3f4 100644
--- a/a/arch/x86/platform/efi/efi.c
+++ b/b/arch/x86/platform/efi/efi.c
@@ -924,6 +924,8 @@ void __init efi_enter_virtual_mode(void)
  new_memmap = krealloc(new_memmap,
       (count + 1) * memmap.desc_size,
       GFP_KERNEL);
+ if (!new_memmap)
+ return -ENOMEM;
  memcpy(new_memmap + (count * memmap.desc_size), md,
        memmap.desc_size);
  count++;
diff --git a/a/fs/ceph/mdsmap.c b/b/fs/ceph/mdsmap.c
index 73b7d44..d04ab8b 100644
--- a/a/fs/ceph/mdsmap.c
+++ b/b/fs/ceph/mdsmap.c
@@ -132,6 +132,8 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end)
  m->m_info[mds].export_targets =
  kcalloc(num_export_targets, sizeof(u32),
  GFP_NOFS);
+ if (m->m_info[mds].export_targets == NULL)
+ goto badmem;
  for (j = 0; j < num_export_targets; j++)
  m->m_info[mds].export_targets[j] =
        ceph_decode_32(&pexport_targets);
diff --git a/a/drivers/isdn/mISDN/fsm.c b/b/drivers/isdn/mISDN/fsm.c
index 26477d4..07040b2 100644
--- a/a/drivers/isdn/mISDN/fsm.c
+++ b/b/drivers/isdn/mISDN/fsm.c
@@ -34,6 +34,8 @@ mISDN_FsmNew(struct Fsm *fsm,

  fsm->jumpmatrix = kzalloc(sizeof(FSMFNPTR) * fsm->state_count *
   fsm->event_count, GFP_KERNEL);
+ if (!fsm->jumpmatrix)
+ return -ENOMEM;

  for (i = 0; i < fncount; i++)
  if ((fnlist[i].state >= fsm->state_count) ||
diff --git a/a/drivers/scsi/megaraid.c b/b/drivers/scsi/megaraid.c
index 9504ec0..37b915f 100644
--- a/a/drivers/scsi/megaraid.c
+++ b/b/drivers/scsi/megaraid.c
@@ -4437,6 +4437,8 @@ mega_internal_command(adapter_t *adapter,
megacmd_t *mc, mega_passthru *pthru)
  memset(scb, 0, sizeof(scb_t));

  sdev = kzalloc(sizeof(struct scsi_device), GFP_KERNEL);
+ if (!sdev)
+ goto err_out;
  scmd->device = sdev;

  memset(adapter->int_cdb, 0, sizeof(adapter->int_cdb));
@@ -4482,6 +4484,11 @@ mega_internal_command(adapter_t *adapter,
megacmd_t *mc, mega_passthru *pthru)
  scsi_free_command(GFP_KERNEL, scmd);

  return rval;
+
+err_out:
+ mutex_unlock(&adapter->int_mtx);
+ scsi_free_command(GFP_KERNEL, scmd);
+ return -ENOMEM;
 }
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html