netdev - Re: [PATCH] ipv6: by default join ff01::1 and in case of forwarding ff01::2 and ff05:2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 10 Feb 2013 15:59:22 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	YOSHIFUJI Hideaki <hideaki@...hifuji.org>
Cc:	netdev@...r.kernel.org, YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH] ipv6: by default join ff01::1 and in case of forwarding ff01::2 and ff05:2

On Sun, Feb 10, 2013 at 11:47:34PM +0900, YOSHIFUJI Hideaki wrote:
> > @@ -611,10 +617,15 @@ static void dev_forward_change(struct inet6_dev *idev)
> >  	if (idev->cnf.forwarding)
> >  		dev_disable_lro(dev);
> >  	if (dev->flags & IFF_MULTICAST) {
> > -		if (idev->cnf.forwarding)
> > +		if (idev->cnf.forwarding) {
> >  			ipv6_dev_mc_inc(dev, &in6addr_linklocal_allrouters);
> > -		else
> > +			ipv6_dev_mc_inc(dev, &in6addr_interfacelocal_allrouters);
> > +			ipv6_dev_mc_inc(dev, &in6addr_sitelocal_allrouters);
> > +		} else {
> >  			ipv6_dev_mc_dec(dev, &in6addr_linklocal_allrouters);
> > +			ipv6_dev_mc_dec(dev, &in6addr_interfacelocal_allrouters);
> > +			ipv6_dev_mc_inc(dev, &in6addr_sitelocal_allrouters);
>                                     ~~~dec?
> > +		}
> >  	}

Yes, that was the broken part. I fixed it locally and then send out the old
patch file.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html