netdev - Re: [PATCHi v2] net: sh_eth: Add support of device tree probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Feb 2013 10:47:27 +0900
From:	Magnus Damm <magnus.damm@...il.com>
To:	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
Cc:	netdev@...r.kernel.org, horms+renesas@...ge.net.au,
	devicetree-discuss@...ts.ozlabs.org, kda@...ux-powerpc.org
Subject: Re: [PATCHi v2] net: sh_eth: Add support of device tree probe

Hi Iwamatsu-san,

On Thu, Feb 14, 2013 at 9:51 AM, Nobuhiro Iwamatsu
<nobuhiro.iwamatsu.yj@...esas.com> wrote:
> This adds support of device tree probe for Renesas sh-ether driver.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
>
> ---
> V2: - Removed ether_setup().
>     - Fixed typo from "sh-etn" to "sh-eth".
>         - Removed "needs-init" and sh-eth,endian from definition of DT.
>         - Changed "sh-eth,edmac-endian" instead of "sh-eth,edmac-big-endain"
>           in definition of DT.
>
>  Documentation/devicetree/bindings/net/sh_ether.txt |   41 +++++
>  drivers/net/ethernet/renesas/sh_eth.c              |  156 +++++++++++++++++---
>  2 files changed, 173 insertions(+), 24 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/sh_ether.txt
>
> diff --git a/Documentation/devicetree/bindings/net/sh_ether.txt b/Documentation/devicetree/bindings/net/sh_ether.txt
> new file mode 100644
> index 0000000..7415e54
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/sh_ether.txt
> @@ -0,0 +1,41 @@
> +* Renesas Electronics SuperH EMAC
> +
> +This file provides information, what the device node
> +for the sh_eth interface contains.
> +
> +Required properties:
> +- compatible:                   "renesas,sh-eth";
> +- interrupt-parent:             The phandle for the interrupt controller that
> +                                services interrupts for this device.
> +- reg:                          Offset and length of the register set for the
> +                                device.
> +- interrupts:                   Interrupt mapping for the sh_eth interrupt
> +                                sources (vector id).
> +- phy-mode:                     String, operation mode of the PHY interface.
> +- sh-eth,register-type:         String, register type of sh_eth.
> +                                Please select "gigabit", "fast-sh4" or
> +                                "fast-sh3-sh2".
> +- sh-eth,phy-id:                PHY id.
> +
> +Optional properties:
> +- local-mac-address:            6 bytes, mac address
> +- sh-eth,no-ether-link:         Set link control by software. When device does
> +                                not support ether-link, set.
> +- sh-eth,ether-link-active-low: Set link check method.
> +                                When detection of link is treated as active-low,
> +                                set.
> +- sh-eth,edmac-big-endian:      Set big endian for sh_eth dmac.
> +                                It work as little endian when this is not set.
> +- sh-etn,needs-init:            Initialization flag.
> +                                When initialize device in probing device, set.

I believe the above still says "sh-etn". Also, it is unclear why you
want this flag at all since it is not used to describe the hardware.

Thanks,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html