netdev - Re: Re: kernel 3.7.6, l2tp, qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 16 Feb 2013 00:54:51 +0200
From:	Denys Fedoryshchenko <denys@...p.net.lb>
To:	Eric Dumazet <eric.dumazet@...il.com>, <netdev@...r.kernel.org>
Subject: Re: Re: kernel 3.7.6, l2tp, qdisc_tx circular locking

Sorry accidentaly deleted my emails, i will try in next 2 days to 
update server with l2tp, and will test everything there, if i can 
reproduce bug.

>diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
>index dcfd64e..7baf88f 100644
>--- a/net/l2tp/l2tp_core.c
>+++ b/net/l2tp/l2tp_core.c
>@@ -1251,8 +1251,11 @@ int l2tp_xmit_skb(struct l2tp_session *session, 
> struct sk_buff *skb, int hdr_len
> 	}
>
> 	l2tp_skb_set_owner_w(skb, sk);
>+	bh_unlock_sock(sk);
>
> 	l2tp_xmit_core(session, skb, fl, data_len);
>+	return ret;
>+
> out_unlock:
> 	bh_unlock_sock(sk);

---
Denys Fedoryshchenko, Network Engineer, Virtual ISP S.A.L.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html