netdev - Re: [Patch net-next v2] netpoll: add some missing _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 16 Feb 2013 11:16:27 +0800
From:	Cong Wang <amwang@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, jiri@...nulli.us, vyasevic@...hat.com,
	stephen@...workplumber.org
Subject: Re: [Patch net-next v2] netpoll: add some missing __rcu marks in
 several places

On Thu, 2013-02-14 at 13:20 -0500, David Miller wrote:
> From: Cong Wang <amwang@...hat.com>
> Date: Thu, 14 Feb 2013 16:37:19 +0800
> 
> > From: Cong Wang <amwang@...hat.com>
> > 
> > This fixes sparse warnings like the one below:
> > 
> > drivers/net/team/team.c:953:25: warning: incorrect type in return expression (different address spaces)
> > drivers/net/team/team.c:953:25:    expected struct netpoll_info *
> > drivers/net/team/team.c:953:25:    got struct netpoll_info [noderef] <asn:4>*npinfo
> > 
> > Cc: Jiri Pirko <jiri@...nulli.us>
> > Cc: Vlad Yasevich <vyasevic@...hat.com>
> > Cc: Stephen Hemminger <stephen@...workplumber.org>
> > Cc: David S. Miller <davem@...emloft.net>
> > Signed-off-by: Cong Wang <amwang@...hat.com>
> 
> This is a very confusing patch submission.
> 
> You're posting a "v2" of a patch but with a completely different Subject
> line so that it's hard, without looking into the details of the patch,
> to determine what this patch is a "v2" of.
> 
> You've also not addressed Stephen's feedback about the lack of an
> rcu_dereference() in these routines you've added __rcu annotations
> to.
> 
> I'm tossing all versions of this patch, therefore.

The reason is we don't dereference ->npinfo pointer, we just check if it
is NULL, so doesn't need to call rcu_dereference(). Or am I missing
anything?

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html