netdev - Re: [Patch net-next v3] net: fix some RCU warnings in various places

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 16 Feb 2013 16:36:40 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, Jiri Pirko <jiri@...nulli.us>,
	Vlad Yasevich <vyasevic@...hat.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net-next v3] net: fix some RCU warnings in various places

On Fri, 2013-02-15 at 22:23 -0800, Eric Dumazet wrote:
> On Sat, 2013-02-16 at 13:48 +0800, Cong Wang wrote:
> > From: Cong Wang <amwang@...hat.com>
> > 
> > This fixes sparse warnings like the one below:
> 
> >  static inline void br_netpoll_send_skb(const struct net_bridge_port *p,
> > @@ -469,7 +469,7 @@ extern void br_multicast_free_pg(struct rcu_head *head);
> >  extern struct net_bridge_port_group *br_multicast_new_port_group(
> >  				struct net_bridge_port *port,
> >  				struct br_ip *group,
> > -				struct net_bridge_port_group *next,
> > +				struct net_bridge_port_group __rcu *next,
> >  				unsigned char state);
> >  extern void br_mdb_init(void);
> >  extern void br_mdb_uninit(void);
> 
> This part is wrong, please remove the __rcu annotation in function
> definition.
> 
> To perform " rcu_assign_pointer(p->next, next); ", there is no need to
> annotate "next" with __rcu
> 

This will introduce more warnings, enjoy. ;)

So I will leave this to Vlad.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html