netdev - Re: [PATCH] ip_gre: remove an extra dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Feb 2013 14:36:26 -0800
From:	Pravin Shelar <pshelar@...ira.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] ip_gre: remove an extra dst_release()

On Tue, Feb 19, 2013 at 2:14 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>
> commit 68c331631143 (v4 GRE: Add TCP segmentation offload for GRE)
> introduced a bug in error path.
>
> dst is attached to skb, so will be released when skb is freed.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Pravin B Shelar <pshelar@...ira.com>

Looks good.

Acked-by: Pravin B Shelar <pshelar@...ira.com>

> ---
>  net/ipv4/ip_gre.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
> index 31bc941..5ef4da7 100644
> --- a/net/ipv4/ip_gre.c
> +++ b/net/ipv4/ip_gre.c
> @@ -1006,10 +1006,8 @@ static netdev_tx_t ipgre_tunnel_xmit(struct sk_buff *skb, struct net_device *dev
>
>                         if (skb_has_shared_frag(skb)) {
>                                 err = __skb_linearize(skb);
> -                               if (err) {
> -                                       ip_rt_put(rt);
> +                               if (err)
>                                         goto tx_error;
> -                               }
>                         }
>
>                         *ptr = 0;
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html