netdev - Re: [PATCH v2] net: fec: Fix the disabling of RX interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Feb 2013 00:19:09 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Frank Li <lznuaa@...il.com>
Cc:	Fabio Estevam <fabio.estevam@...escale.com>, davem@...emloft.net,
	Frank.Li@...escale.com, shawn.guo@...aro.org, marex@...x.de,
	s.hauer@...gutronix.de, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: fec: Fix the disabling of RX interrupt

On Mon, Feb 18, 2013 at 11:47 PM, Frank Li <lznuaa@...il.com> wrote:

> This is similar with my first implement.

I checked your original implementation and
spin_lock_irqsave/spin_unlock_irqrestore was very far apart.

> It just protect irq and init function. Many place write FEC_IMASK directly.

Yes, but the main issue with current code is that it does not clear
the only rx irq as it should.

> I think this issue was caused by enable irq before register irq handler.
> writel(0, fep->hwp + FEC_IMASK) should fix mx53's problem.

No, it does not solve the issue.

I don't have a mx6q board handy. If you could try this patch and let
me know if you see any deadlock, it would be nice.

Thanks,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html