netdev - Re: [PATCH] net: fec: Fix division by zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 Feb 2013 15:14:29 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	fabio.estevam@...escale.com
Cc:	Frank.Li@...escale.com, s.hauer@...gutronix.de,
	jim_baxter@...tor.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: fec: Fix division by zero

From: Fabio Estevam <fabio.estevam@...escale.com>
Date: Fri, 22 Feb 2013 13:40:45 -0300

> commit 7f7d6c282 (net: fec: Ensure that initialization is done prior to 
> request_irq()) placed fec_ptp_init() into a point that ptp clock was not 
> available, which causes a division by zero in fec_ptp_start_cyclecounter():
> 
> [   17.895723] Division by zero in kernel.
> [   17.899571] Backtrace:
> [   17.902094] [<80012564>] (dump_backtrace+0x0/0x10c) from [<8056deec>]
> (dump_stack+0x18/0x1c)
> [   17.910539]  r6:bfba8500 r5:8075c950 r4:bfba8000 r3:bfbd0000
> [   17.916284] [<8056ded4>] (dump_stack+0x0/0x1c) from [<80012688>]
> (__div0+0x18/0x20)
> [   17.923968] [<80012670>] (__div0+0x0/0x20) from [<802829c4>] (Ldiv0+0x8/0x10)
> [   17.931140] [<80398534>] (fec_ptp_start_cyclecounter+0x0/0x110) from
> [<80394f64>] (fec_restart+0x6c8/0x754)
> [   17.940898] [<8039489c>] (fec_restart+0x0/0x754) from [<803969a0>]
> (fec_enet_adjust_link+0xdc/0x108)
> [   17.950046] [<803968c4>] (fec_enet_adjust_link+0x0/0x108) from [<80390bc4>]
> (phy_state_machine+0x178/0x534)
> ...
> 
> Fix this by rearraging the code so that fec_ptp_init() is called only after
> the clocks have been properly acquired.
> 
> Tested on both mx53 and mx6 platforms.
> 
> Reported-by: Jim Baxter <jim_baxter@...tor.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html