netdev - Re: [PATCH] net/pasemi: Fix missing coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 24 Feb 2013 16:53:09 -0800
From:	Olof Johansson <olof@...om.net>
To:	Joe Perches <joe@...ches.com>
Cc:	Syam Sidhardhan <syamsidhardh@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] net/pasemi: Fix missing coding style

On Sun, Feb 24, 2013 at 3:29 PM, Joe Perches <joe@...ches.com> wrote:
> On Sun, 2013-02-24 at 15:23 -0800, Joe Perches wrote:
>> On Mon, 2013-02-25 at 04:31 +0530, Syam Sidhardhan wrote:
>> > Fix missing () & { }
>> []
>> > diff --git a/drivers/net/ethernet/pasemi/pasemi_mac.c b/drivers/net/ethernet/pasemi/pasemi_mac.c
>> []
>> > @@ -1829,10 +1831,11 @@ pasemi_mac_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>> >             dev_err(&mac->pdev->dev, "register_netdev failed with error %d\n",
>> >                     err);
>> >             goto out;
>> > -   } else if netif_msg_probe(mac)
>> > +   } else if (netif_msg_probe(mac)) {
>> >             printk(KERN_INFO "%s: PA Semi %s: intf %d, hw addr %pM\n",
>> >                    dev->name, mac->type == MAC_TYPE_GMAC ? "GMAC" : "XAUI",
>> >                    mac->dma_if, dev->dev_addr);
>> > +   }
>> >
>> >     return err;
>> >
>>
>> Uncompilable since 2007!
>> That argues more for removal than anything else.

This driver is still used by several people running upstream kernels,
including myself. Removal is out of the question.

> Nevermind. Not true.
> netif_msg_probe is already surrounded by parens.
> It's just stylistic ugly.

Yeah, not sure how that one made it through way back then. Worth
fixing so it doesn't bite later if netif_msg_probe() is changed.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html