netdev - Re: [PATCH net-next 1/4] net: Add skb_headers_offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 7 Mar 2013 23:23:02 -0800
From:	Pravin Shelar <pshelar@...ira.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, jesse@...ira.com
Subject: Re: [PATCH net-next 1/4] net: Add skb_headers_offset_update helper function.

On Thu, Mar 7, 2013 at 9:40 PM, Stephen Hemminger
<stephen@...workplumber.org> wrote:
> On Thu,  7 Mar 2013 15:21:40 -0800
> Pravin B Shelar <pshelar@...ira.com> wrote:
>
>> +static void skb_headers_offset_update(struct sk_buff *skb, int off)
>> +{
>> +     /* {transport,network,mac}_header and tail are relative to skb->head */
>> +     skb->transport_header += off;
>> +     skb->network_header   += off;
>> +     if (skb_mac_header_was_set(skb))
>> +             skb->mac_header += off;
>> +     skb->inner_transport_header += off;
>> +     skb->inner_network_header += off;
>> +}
>> +
>
> Won't this cause an unused function warning if NET_SKBUFF_DATA_USES_OFFSET is defined?

This function is used in both cases, so it should be ok.

Thanks,
Pravin.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html