netdev - Re: [PATCH] ipv6 addrconf: Fix addrconf_ifid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 09 Mar 2013 13:34:22 +0900
From:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
To:	Alexander Aring <alex.aring@...il.com>
CC:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>, davem@...emloft.net,
	kuznet@....inr.ac.ru, jmorris@...ei.org,
	linux-zigbee-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6 addrconf: Fix addrconf_ifid_eui64 of 802.15.4 devices

YOSHIFUJI Hideaki wrote:
> Alexander Aring wrote:
:
>> With your patch, which isn't working anymore:
>>
>> iphc0 = 7b, iphc1 = 3b
>> NH flag is set, next header carried inline: 3a
>> source address stateless compression
>> (lowpan_uncompress_addr) linklocal address: 
>> 02 85 00 3a 20 00 00 00
>> uncompressing 2 + 0 => 
>> fe 80 00 00 00 00 00 00 00 85 00 3a 20 00 00 00
>> dest: non context-based mcast compression
>> uncompressing 2 + 1 => 
>> ff 02 00 00 00 00 00 00 00 00 00 00 00 00 00 02
>> skb headroom size = 25, data length = 24
>> IPv6 header dump:
>> 	version = 6
>> 	length  = 24
>> 	nexthdr = 0x3a
>> 	hop_lim = 255
>>
>> And for every ipv6 packet I got:
>> ICMPv6 checksum failed [fe80:0000:0000:0000:0001:ff00:0001:8700 > ff02:0000:0000:0000:0000:0001:ff00:0001]
>>
>> I seems that the reconstructed destination address and header length are
>> not right.
> 
> That's wired.  It is expected to work whatever valid source/destination
> addesses are used, right?

It seems the last argument for lowpan_uncompress_address() (lladdr,
show as "linklocal address") is incorrect.
Note that it should say link-"layer" address, BTW.

--yoshfuji
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html