netdev - Re: [PATCH net-next] Remove unused tw_cookie_values from tcp_timewait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Mar 2013 17:06:10 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Christoph Paasch <christoph.paasch@...ouvain.be>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	william.allen.simpson@...il.com
Subject: Re: [PATCH net-next] Remove unused tw_cookie_values from
 tcp_timewait_sock

On Sun, 2013-03-10 at 16:18 +0100, Christoph Paasch wrote:
> tw_cookie_values is never used in the TCP-stack.
> 
> It was added by 435cf559f (TCPCT part 1d: define TCP cookie option,
> extend existing struct's), but already at that time it was not used at
> all, nor mentioned in the commit-message.
> 
> Signed-off-by: Christoph Paasch <christoph.paasch@...ouvain.be>
> ---
>  include/linux/tcp.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/include/linux/tcp.h b/include/linux/tcp.h
> index f28408c..515c374 100644
> --- a/include/linux/tcp.h
> +++ b/include/linux/tcp.h
> @@ -361,10 +361,6 @@ struct tcp_timewait_sock {
>  #ifdef CONFIG_TCP_MD5SIG
>  	struct tcp_md5sig_key	  *tw_md5_key;
>  #endif
> -	/* Few sockets in timewait have cookies; in that case, then this
> -	 * object holds a reference to them (tw_cookie_values->kref).
> -	 */
> -	struct tcp_cookie_values  *tw_cookie_values;
>  };
>  
>  static inline struct tcp_timewait_sock *tcp_twsk(const struct sock *sk)

Acked-by: Eric Dumazet <edumazet@...gle.com>

Actually, I am not sure TCPCT is really used...



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html