lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Mar 2013 00:05:56 +0200 (EET) From: Julian Anastasov <ja@....bg> To: David Miller <davem@...emloft.net> cc: horms@...ge.net.au, lvs-devel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCHv2 net-next 01/15] net: add skb_dst_set_unref Hello, On Sun, 10 Mar 2013, David Miller wrote: > From: Julian Anastasov <ja@....bg> > Date: Sun, 10 Mar 2013 15:37:34 +0200 (EET) > > > The idea looks good, here is the implementation. > > Can I use it in this form for next patchset versions? > > Yes, but with one minor change: > > > - if (unlikely(dst->flags & DST_NOCACHE)) { > > + if (unlikely(dst->flags & DST_NOCACHE && !force)) { > > I keep forgetting the && vs. & operator precedence, and so > do many other people, so please put parenthesis around > the "dst->flags & DST_NOCACHE" expression, thanks. Done, I'll wait a week for more feedback... Regards -- Julian Anastasov <ja@....bg> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists