netdev - Re: [PATCH 1/1] Fix dst_neigh_lookup/dst_neigh_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Mar 2013 05:26:20 +0000 (UTC)
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	netdev@...r.kernel.org
Cc:	linux-rdma@...r.kernel.org
Subject: Re: [PATCH 1/1] Fix dst_neigh_lookup/dst_neigh_lookup_skb return
 value handling bug

On Thu, 14 Mar 2013 at 03:41 GMT, Zhouyi Zhou <zhouzhouyi@...il.com> wrote:
> Tested on my x86_64 machine
>
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@...il.com>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c |   12 ++++++++++++
>  include/net/dst.h                |    6 ++++--
>  2 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index 565bfb1..6b95851 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -1575,6 +1575,12 @@ static int c4iw_reconnect(struct c4iw_ep *ep)
>  
>  	neigh = dst_neigh_lookup(ep->dst,
>  			&ep->com.cm_id->remote_addr.sin_addr.s_addr);
> +	if (!neigh) {
> +		pr_err("%s - cannot alloc neigh.\n", __func__);
> +		err = -ENOMEM;
> +		goto fail4;


You don't need to print error messages for OOM, the mm subsystem will
do.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html