lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Mar 2013 10:15:00 +0000 From: Arnd Bergmann <arnd@...db.de> To: Geert Uytterhoeven <geert@...ux-m68k.org> Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Karsten Keil <isdn@...ux-pingi.de>, netdev@...r.kernel.org, David Howells <dhowells@...hat.com> Subject: Re: [PATCH] isdn: hisax: netjet requires VIRT_TO_BUS On Friday 15 March 2013, Geert Uytterhoeven wrote: > On Thu, Mar 14, 2013 at 10:56 PM, Arnd Bergmann <arnd@...db.de> wrote: > > Disabling CONFIG_VIRT_TO_BUS on ARM showed that the hisax netjet > > driver depends on this deprecated functionality but is not > > marked so in Kconfig. > > > > Rather than adding ARM to the already long list of architectures > > that this driver is broken on, this patch adds 'depends on > > VIRT_TO_BUS' and removes the dependency on !SPARC, which is > > also implied by that. > > IIRC, the real "arch" dependency for this driver is !BIG_ENDIAN, but > unfortunately > we don't have a generic Kconfig symbol for that. > Perhaps we may want to introduce that? > Of course we prefer to make drivers work on all endianness instead... CONFIG_VIRT_TO_BUS is certainly also a dependency, since it fails to build without that. I think we can address the two problems separately. David Howells brought up the topic of endian checks recently, noting that the way we define __BIG_ENDIAN and __LITTLE_ENDIAN in the kernel is incompatible to how do it in user space, and not much better either. A few architectures that are bi-endian (arc, arm, c6x, mips, sh) already have CONFIG_CPU_IS_LITTLE_ENDIAN and CONFIG_CPU_IS_BIG_ENDIAN. I guess it would be a good idea to provide these on all architectures. Arnd -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists