| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Mar 2013 12:54:49 -0700 From: Maciej Żenczykowski <zenczykowski@...il.com> To: David Miller <davem@...emloft.net> Cc: eilong@...adcom.com, eric.dumazet@...il.com, dmitry@...adcom.com, netdev@...r.kernel.org, yuvalmin@...adcom.com Subject: Re: [PATCH] bnx2x: fix occasional statistics off-by-4GB error I've reproduced this in the lab. I can confirm this patch fixes per-queue statistics (ie. ethtool -S "[0]: tx_bytes") - which previously were not monotonically increasing. However there is still a bug wrt. global device stats (ie. ethtool -S "tx_bytes" and /proc/net/dev transmit bytes). I'm guessing there's another similar bug later on during aggregation. I expect to find the offending code and send out a patch soon. On Mon, Mar 18, 2013 at 10:13 AM, David Miller <davem@...emloft.net> wrote: > From: "Eilon Greenstein" <eilong@...adcom.com> > Date: Mon, 18 Mar 2013 12:06:22 +0200 > >> Maciej - thanks for the detailed information. You are right - it has >> nothing to do with the HW/FW and it is simply a bug that needs to be >> fixed. I withdraw my objections and add my ACK. >> >> Acked-by: Eilon Greenstein <eilong@...adcom.com> > > Applied and queued up for -stable. > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists