netdev - RE: [PATCH net-next 2/2] bnx2x: add RSS capability for GRE traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Mar 2013 06:30:36 +0000
From:	"Dmitry Kravkov" <dmitry@...adcom.com>
To:	"Eric Dumazet" <eric.dumazet@...il.com>
cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Eilon Greenstein" <eilong@...adcom.com>,
	"Tom Herbert" <therbert@...gle.com>,
	Maciej Żenczykowski <maze@...gle.com>
Subject: RE: [PATCH net-next 2/2] bnx2x: add RSS capability for GRE
 traffic

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] On Behalf Of Eric Dumazet
> Sent: Tuesday, March 19, 2013 2:08 AM
> To: Dmitry Kravkov
> Cc: davem@...emloft.net; netdev@...r.kernel.org; Eilon Greenstein; Tom Herbert; Maciej Żenczykowski
> Subject: Re: [PATCH net-next 2/2] bnx2x: add RSS capability for GRE traffic
> 
> On Mon, 2013-03-18 at 18:51 +0200, Dmitry Kravkov wrote:
> > The patch drives FW to perform RSS for GRE traffic,
> > based on inner headers.
> >
> > Signed-off-by: Dmitry Kravkov <dmitry@...adcom.com>
> > Signed-off-by: Eilon Greenstein <eilong@...adcom.com>
> > ---
> >  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h |    3 +++
> >  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c  |   23 ++++++++++++-----------
> >  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.h  |    9 +++++++++
> >  3 files changed, 24 insertions(+), 11 deletions(-)
> 
> This works very well.
> 
> Problem is we skb_set_queue_mapping(skb, 0); in __skb_tunnel_rx()
> 
> (this was a patch from Tom Herbert, commit
> 693019e90ca45d881109d32c0c6d29adf03f6447 (net: reset skb queue mapping
> when rx'ing over tunnel )
> 
> Meaning we hit a single cpu for the GRO stuff in ip_gre.
> 
> I have to think about it.
> 
> 
> Another question is :
> 
> Can bnx2x check the tcp checksum if GRE encapsulated ?
> 
Current HW can't provide this. Probably, it's possible to separate CSUM from GRO/TPA then stack will have to handle CSUM validation for huge packets. Is it worth?