netdev - Re: [PATCH] fec: Unify fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Mar 2013 18:02:02 +0800
From:	Frank Li <lznuaa@...il.com>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	Fabio Estevam <festevam@...il.com>, davem@...emloft.net,
	Frank.Li@...escale.com, netdev@...r.kernel.org,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] fec: Unify fec_ptp.c and fec.c

I suggest use below patch to fix this problem

--- a/drivers/net/ethernet/freescale/Makefile
+++ b/drivers/net/ethernet/freescale/Makefile
@@ -2,7 +2,8 @@
 # Makefile for the Freescale network device drivers.
 #

-obj-$(CONFIG_FEC) += fec.o fec_ptp.o
+obj-$(CONFIG_FEC) += fec_driver.o
+fec_driver-objs := fec.o fec_ptp.o
 obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx.o
 ifeq ($(CONFIG_FEC_MPC52xx_MDIO),y)
        obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx_phy.o


2013/3/21 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>:
> Hello Fabio,
>
> On Wed, Mar 20, 2013 at 05:11:07PM -0300, Fabio Estevam wrote:
>> Currently CONFIG_FEC=y generates two separate modules: fec_ptp.ko and fec.ko.
> CONFIG_FEC=m
>
>> These modules cannot be used independently, so it is better to unify them.
>>
>> Move fec_ptp.c code into fec.c and its definitions into fec.h.
>>
>> Suggested-by: Uwe Kleine-Koenig <u.kleine-koenig@...gutronix.de>
> s/Koe/Kö/
>
>> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
>
> You could note that you dropped the EXPORT_SYMBOLs. Other than that I
> assume it's a 1:1 change?
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html