netdev - [PATCH net] ipv4: Fix ip-header identification for gso packets.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 23 Mar 2013 21:10:48 -0700
From:	Pravin B Shelar <pshelar@...ira.com>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org, Pravin B Shelar <pshelar@...ira.com>
Subject: [PATCH net] ipv4: Fix ip-header identification for gso packets.

For TCP protocol ip-header id needs to be incremented even if
IP_DF flag is set. This behaviour was changed in commit
490ab08127cebc25e3a26 (IP_GRE: Fix IP-Identification).

Following patch fixes it so that identification is always
incremented for TCP.

Reported-by: Cong Wang <amwang@...hat.com>
Signed-off-by: Pravin B Shelar <pshelar@...ira.com>

---
 net/ipv4/af_inet.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index 9e5882c..4958b9d 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1334,7 +1334,7 @@ static struct sk_buff *inet_gso_segment(struct sk_buff *skb,
 				iph->frag_off |= htons(IP_MF);
 			offset += (skb->len - skb->mac_len - iph->ihl * 4);
 		} else  {
-			if (!(iph->frag_off & htons(IP_DF)))
+			if (proto == IPPROTO_TCP || !(iph->frag_off & htons(IP_DF)))
 				iph->id = htons(id++);
 		}
 		iph->tot_len = htons(skb->len - skb->mac_len);
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html