netdev - Re: [PATCH v2 1/1]core:Change a wrong explain about dev_get_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Mar 2013 19:44:10 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	tingwei liu <tingw.liu@...il.com>
CC:	netdev@...r.kernel.org, Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	davem@...emloft.net, Eric Dumazet <eric.dumazet@...il.com>,
	Ben Hutchings <bhutchings@...arflare.com>,
	Linus Torvalds <linus971@...il.com>
Subject: Re: [PATCH v2 1/1]core:Change a wrong explain about dev_get_by_name

Hello.

On 25-03-2013 8:10, tingwei liu wrote:

> From: Tingwei Liu <tingw.liu@...il.com>
> Date: Mon, 25 Mar 2013 11:09:59 +0800
> Subject: [PATCH] Change a wrong explain about dev_get_by_name

> a long time ago by the  commit.

    Did you mean "before the commit"?

>   commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
>   Author: Linus Torvalds <torvalds@...970.osdl.org>
>   Date:   Sat Apr 16 15:20:36 2005 -0700

>      Linux-2.6.12-rc2

>      Initial git repository build. I'm not bothering with the full history,
>      even though we have it. We can create a separate "historical" git
>      archive of that later if we want to, and in the meantime it's about
>      3.2GB when imported into git - space that would just make the early
>      git days unnecessarily complicated, when we don't have a lot of good
>      infrastructure for it.

>      Let it rip!

> When function "list_netdevice" get write lock "dev_base_lock" only
> disable soft interrupt. So dev_get_by_name get read lock
> "dev_base_lock", can not called on interrupt context.

> Signed-off-by: Tingwei Liu <tingw.liu@...il.com>
> ---
> Changes from v1:
> - add change log
> - add the commnet
>
>   net/core/dev.c |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index d540ced..20c5c7c 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -700,10 +700,10 @@ EXPORT_SYMBOL(dev_get_by_name_rcu);
>   *     @name: name to find
>   *
>   *     Find an interface by name. This can be called from any
> - *     context and does its own locking. The returned handle has
> - *     the usage count incremented and the caller must use dev_put() to
> - *     release it when it is no longer needed. %NULL is returned if no
> - *     matching device is found.
> + *     context except hard irq context and does its own locking.
> + *     The returned handle has the usage count incremented and the
> + *     caller must use dev_put() to release it when it is no longer
> + *     needed. %NULL is returned if no matching device is found.

    It seems your patch has all the tabs replaced by spaces.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html