netdev - Re: [net-next PATCH 1/1] drivers: net: ethernet: ti: sparse warning fix for ti ethernet drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Mar 2013 13:08:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mugunthanvnm@...com
Cc:	netdev@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [net-next PATCH 1/1] drivers: net: ethernet: ti: sparse
 warning fix for ti ethernet drivers

From: Mugunthan V N <mugunthanvnm@...com>
Date: Wed, 27 Mar 2013 15:28:07 +0530

> @@ -179,7 +179,7 @@ cpdma_desc_pool_create(struct device *dev, u32 phys, u32 hw_addr,
>  	} else {
>  		pool->cpumap = dma_alloc_coherent(dev, size, &pool->phys,
>  						  GFP_KERNEL);
> -		pool->iomap = pool->cpumap;
> +		pool->iomap = (void __iomem *) pool->cpumap;

This is bogus.

Either a pointer is to RAM, or it's an IOMEM pointer.  It cannot be both.

This indicates that pool->iomap's usage in this scenerio is not correct
at all.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html