netdev - Re: [PATCH] yam: avoid null pointer dereference error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Mar 2013 14:14:18 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	colin.king@...onical.com, jpr@...bb.org,
	linux-hams@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] yam: avoid null pointer dereference error

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Wed, 27 Mar 2013 18:12:33 +0000

> On Wed, 2013-03-27 at 18:08 +0000, Colin Ian King wrote:
>> On 27/03/13 17:46, David Miller wrote:
>> > From: Ben Hutchings <bhutchings@...arflare.com>
>> > Date: Wed, 27 Mar 2013 17:44:17 +0000
>> >
>> >> On Wed, 2013-03-27 at 11:19 +0000, Colin King wrote:
>> >>> From: Colin Ian King <colin.king@...onical.com>
>> >>>
>> >>> yam_open checks if dev is null, however, before that check it
>> >>> accesses some of the fields from dev in a proceeding printk which
>> >>> will cause a null pointer dereference error if dev is nul. Move
>> >>> the printk to after the null check.
>> >>
>> >> This function will never be called with dev == NULL.
>> >
>> > Then let's remove at least that part of the check.
>> >
>> Good point. How about the following..
> 
>> From 564f111f196d9d7293e922a68ba973210d191129 Mon Sep 17 00:00:00 2001
>> From: Colin Ian King <colin.king@...onical.com>
>> Date: Wed, 27 Mar 2013 13:59:05 -0400
>> Subject: [PATCH] yam: remove redundant null check on dev
>> 
>> yam_open has a redundant null check on null,  it will
>> never be called with dev == NULL. Remove this redundant check.
>> This also cleans up a smatch warning:
>> 
>> drivers/net/hamradio/yam.c:869 yam_open() warn: variable
>>   dereferenced before check 'dev' (see line 867)
>> 
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> Reviewed-by: Ben Hutchings <bhutchings@...arflare.com>

Colin, please formally resubmit this using a fresh mailing list
posting rather than as a reply in this thread.  Please incorporate
Ben's reviewed-by tag when doing so, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html