netdev - Re: [PATCH regression/bisected] Revert "brcmsmac: support 4313iPA"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Mar 2013 16:32:28 +0100
From:	David Herrmann <dh.herrmann@...il.com>
To:	"John W. Linville" <linville@...driver.com>
Cc:	Piotr Haber <phaber@...adcom.com>, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Arend van Spriel <arend@...adcom.com>,
	brcm80211-dev-list@...adcom.com, netdev@...r.kernel.org,
	Pieter-Paul Giesberts <pieterpg@...adcom.com>
Subject: Re: [PATCH regression/bisected] Revert "brcmsmac: support 4313iPA"

Hi John

On Wed, Mar 27, 2013 at 3:56 PM, John W. Linville
<linville@...driver.com> wrote:
> On Tue, Mar 26, 2013 at 10:31:00AM +0100, Piotr Haber wrote:
>> On 03/25/13 19:58, John W. Linville wrote:
>> > On Mon, Mar 18, 2013 at 02:58:08PM +0100, David Herrmann wrote:
>> >> Hi Piotr
>> >>
>> >> On Mon, Mar 18, 2013 at 2:49 PM, Piotr Haber <phaber@...adcom.com> wrote:
>> >>> On 03/18/13 11:45, David Herrmann wrote:
>> >>>> This reverts commit b6fc28a158076ca2764edc9a6d1e1402f56e1c0c. It breaks
>> >>>> wireless AP reconnection on: (14e4:4727)
>> >>>>   Broadcom Corporation BCM4313 802.11b/g/n Wireless LAN Controller
>> >>>>
>> >>>> Any attempt to reconnect to an AP results in timeouts no matter how near to the
>> >>>> AP I am:
>> >>>>  00:10:40 $nb kernel: wlan0: authenticate with 00:18:39:0a:8e:23
>> >>>>  00:10:40 $nb kernel: wlan0: direct probe to 00:18:39:0a:8e:23 (try 1/3)
>> >>>>  00:10:40 $nb kernel: wlan0: direct probe to 00:18:39:0a:8e:23 (try 2/3)
>> >>>>  00:10:41 $nb kernel: wlan0: direct probe to 00:18:39:0a:8e:23 (try 3/3)
>> >>>>  00:10:41 $nb kernel: wlan0: authentication with 00:18:39:0a:8e:23 timed out
>> >>>> ---
>> >>>> Hi
>> >>>>
>> >>>> I tried coming up with a fix instead of reverting this commit, but the commit is
>> >>>> way to big for me to understand what's going on. Sorry.
>> >>>>
>> >>>> With linux-3.8 connecting to an AP broke on my machine. I could connect to an AP
>> >>>> one time, but any further attempt resulted in:
>> >>>>  00:10:40 $nb kernel: wlan0: authenticate with 00:18:39:0a:8e:23
>> >>>>  00:10:40 $nb kernel: wlan0: direct probe to 00:18:39:0a:8e:23 (try 1/3)
>> >>>>  00:10:40 $nb kernel: wlan0: direct probe to 00:18:39:0a:8e:23 (try 2/3)
>> >>>>  00:10:41 $nb kernel: wlan0: direct probe to 00:18:39:0a:8e:23 (try 3/3)
>> >>>>  00:10:41 $nb kernel: wlan0: authentication with 00:18:39:0a:8e:23 timed out
>> >>>>
>> >>>> Even sitting right next to the AP didn't help so I started bisecting and it
>> >>>> turned out to be:
>> >>>>   "brcmsmac: support 4313iPA" b6fc28a158076ca2764edc9a6d1e1402f56e1c0c
>> >>>> Please revert it.
>> >>>>
>> >>>> Thanks
>> >>>> David
>> >>>>
>> >>> Hi,
>> >>> unfortunately this is not a first report of this patch breaking 4313 for some users.
>> >>> I'm pretty confident that it is hardware revision related as we have 4313ePA and iPA boards running
>> >>> successfully in our test setup.
>> >>> Could you aid us in effort of finding the problem by supplying the contents of this debugfs file:
>> >>> <debugfs_mount>/brcmsmac/bcma0:0/hardware
>> >>
>> >> Hi
>> >>
>> >> $ cat /sys/kernel/debug/brcmsmac/bcma0\:0/hardware
>> >> board vendor: 185f
>> >> board type: 51a
>> >> board revision: 1408
>> >> board flags: 8402a01
>> >> board flags2: 880
>> >> firmware revision: 262032b
>> >>
>> >> I can also try partial reverts of that commit, but I really don't know
>> >> which parts might be important.
>> >
>> > Are we going to see a fix for this (very) soon?  Or should I just go
>> > ahead and revert this patch?
>> >
>> I cannot reproduce the issue on a set of devices we have here (3 different 4313 ePA models).
>> Some of the devices that are reported to be broken are being shipped to us.
>> So I would say we need around 2 weeks at least to resolve this (if we reproduce the problem and find
>> a fix).
>> Not sure this is soon enough.
>> If not please go ahead an revert the patch.
>
> I am reverting the patch.

Can you CC stable? Otherwise I will try to sent it to them after you applied it.

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html