netdev - Re: [PATCH] bonding: fix disabling of arp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 29 Mar 2013 15:03:28 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nikolay@...hat.com
Cc:	netdev@...r.kernel.org, andy@...yhouse.net, fubar@...ibm.com
Subject: Re: [PATCH] bonding: fix disabling of arp_interval and miimon

From: Nikolay Aleksandrov <nikolay@...hat.com>
Date: Wed, 27 Mar 2013 14:32:41 +0100

> Currently if either arp_interval or miimon is disabled, they both get
> disabled, and upon disabling they get executed once more which is not
> the proper behaviour. Also when doing a no-op and disabling an already
> disabled one, the other again gets disabled.
> Also fix the error messages with the proper valid ranges, and a small
> typo fix in the up delay error message (outputting "down delay", instead
> of "up delay").
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...hat.com>

Indeed the existing code looks completely wrong.

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html