lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 Apr 2013 15:00:34 +0800 From: dingtianhong <dingtianhong@...wei.com> To: Rami Rosen <roszenrami@...il.com> CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Netdev <netdev@...r.kernel.org>, Li Zefan <lizefan@...wei.com> Subject: Re: [PATCH] af_unix: fix build warning On 2013/4/3 20:27, Rami Rosen wrote: > Hi, > Which version of gcc are you using ? > A patch like yours, for the same method, unix_bind(), was sent in the > past, and Stephen Hemminger noted the > with gcc 4.7 the warning you got does not occur. > see: > http://permalink.gmane.org/gmane.linux.network/247807 > > Best Regards, > > Rami Rosen > http://ramirose.wix.com/ramirosen > ok,thanks > > On Wed, Apr 3, 2013 at 12:31 PM, dingtianhong <dingtianhong@...wei.com> wrote: >> net/unix/af_unix.c: In function ‘unix_bind’: >> net/unix/af_unix.c:892: warning: ‘path.mnt’ may be used uninitialized in this function >> net/unix/af_unix.c:892: warning: ‘path.dentry’ may be used uninitialized in this function >> >> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com> >> --- >> net/unix/af_unix.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c >> index 971282b..3ccc049 100644 >> --- a/net/unix/af_unix.c >> +++ b/net/unix/af_unix.c >> @@ -889,7 +889,7 @@ static int unix_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) >> atomic_set(&addr->refcnt, 1); >> >> if (sun_path[0]) { >> - struct path path; >> + struct path path = {}; >> umode_t mode = S_IFSOCK | >> (SOCK_INODE(sock)->i_mode & ~current_umask()); >> err = unix_mknod(sun_path, mode, &path); >> -- >> 1.8.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe netdev" in >> the body of a message to majordomo@...r.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists