netdev - Re: [PATCH net-next] bridge: remove a redundant synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Apr 2013 17:35:30 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, vfalico@...hat.com,
	netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH net-next] bridge: remove a redundant synchronize_net()

Tue, Apr 02, 2013 at 06:27:57PM CEST, eric.dumazet@...il.com wrote:
>On Tue, 2013-04-02 at 12:12 -0400, David Miller wrote:
>
>> Note that we have a few spots now that do two synchronize_net()'s per
>> opertaion, such as team port removal, and openvswitch has such a path
>> as well.  They all are of the form:
>> 
>> 	netdev_rx_handler_unregister()
>> 	...
>> 	lots of other stuff
>> 	...
>> 	synchronize_net();
>> 
>> So might be harder to factor back out than this br_if.c case.
>> 
>
>Strange, I do see call_rcu() in openvswitch, not a synchronize_{net|
>rcu}(). Probably OK to leave as is, as it's not a big deal.
>
>I'll let Jiri handle the team driver change, as its not clear what
>synchronize_rcu() call in team_port_del() is protecting

It can be converted now to call_rcu. synchronize_rcu is making sure
no packet is in flight when changing modes.

>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html