netdev - Re: [PATCH] bonding: remove sysfs before removing devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 05 Apr 2013 00:50:15 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vfalico@...hat.com
Cc:	netdev@...r.kernel.org, fubar@...ibm.com, andy@...yhouse.net,
	nikolay@...hat.com
Subject: Re: [PATCH] bonding: remove sysfs before removing devices

From: Veaceslav Falico <vfalico@...hat.com>
Date: Wed,  3 Apr 2013 17:46:33 +0200

> We have a race condition if we try to rmmod bonding and simultaneously add
> a bond master through sysfs. In bonding_exit() we first remove the devices
> (through rtnl_link_unregister() ) and only after that we remove the sysfs.
> If we manage to add a device through sysfs after that the devices were
> removed - we'll end up with that device/sysfs structure and with the module
> unloaded.
> 
> Fix this by first removing the sysfs and only after that calling
> rtnl_link_unregister().
> 
> Signed-off-by: Veaceslav Falico <vfalico@...hat.com>

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html