lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 7 Apr 2013 13:51:53 +0200 From: Mathias Krause <minipli@...glemail.com> To: "David S. Miller" <davem@...emloft.net> Cc: netdev@...r.kernel.org, Allan Stephens <allan.stephens@...driver.com>, Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>, Andy King <acking@...are.com>, Arnaldo Carvalho de Melo <acme@...stprotocols.net>, Dmitry Torokhov <dtor@...are.com>, George Zhang <georgezhang@...are.com>, Gustavo Padovan <gustavo@...ovan.org>, Johan Hedberg <johan.hedberg@...il.com>, Jon Maloy <jon.maloy@...csson.com>, Lauro Ramos Venancio <lauro.venancio@...nbossa.org>, Marcel Holtmann <marcel@...tmann.org>, Ralf Baechle <ralf@...ux-mips.org>, Samuel Ortiz <sameo@...ux.intel.com>, Samuel Ortiz <samuel@...tiz.org>, Sjur Braendeland <sjur.brandeland@...ricsson.com>, Ursula Braun <ursula.braun@...ibm.com>, Brad Spengler <spender@...ecurity.net>, Mathias Krause <minipli@...glemail.com> Subject: [PATCH 07/16] irda: Fix missing msg_namelen update in irda_recvmsg_dgram() The current code does not fill the msg_name member in case it is set. It also does not set the msg_namelen member to 0 and therefore makes net/socket.c leak the local, uninitialized sockaddr_storage variable to userland -- 128 bytes of kernel stack memory. Fix that by simply setting msg_namelen to 0 as obviously nobody cared about irda_recvmsg_dgram() not filling the msg_name in case it was set. Cc: Samuel Ortiz <samuel@...tiz.org> Signed-off-by: Mathias Krause <minipli@...glemail.com> --- net/irda/af_irda.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/irda/af_irda.c b/net/irda/af_irda.c index d28e7f0..e493b33 100644 --- a/net/irda/af_irda.c +++ b/net/irda/af_irda.c @@ -1386,6 +1386,8 @@ static int irda_recvmsg_dgram(struct kiocb *iocb, struct socket *sock, IRDA_DEBUG(4, "%s()\n", __func__); + msg->msg_namelen = 0; + skb = skb_recv_datagram(sk, flags & ~MSG_DONTWAIT, flags & MSG_DONTWAIT, &err); if (!skb) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists