| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Apr 2013 11:53:16 +0200 From: Oliver Neukum <oliver@...kum.org> To: Ming Lei <tom.leiming@...il.com> Cc: Dan Williams <dcbw@...hat.com>, Elina Pasheva <epasheva@...rrawireless.com>, Network Development <netdev@...r.kernel.org>, linux-usb <linux-usb@...r.kernel.org>, Rory Filer <rfiler@...rrawireless.com>, Phil Sutter <phil@....cc> Subject: Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active On Thursday 11 April 2013 16:09:16 Ming Lei wrote: > On Thu, Apr 11, 2013 at 2:50 PM, Oliver Neukum <oliver@...kum.org> wrote: > > On Thursday 11 April 2013 10:31:31 Ming Lei wrote: > > > >> 'mem_flags' isn't needed any more since we can apply allocation > >> of GFP_NOIO automatically in resume path now, and you can always > >> use GFP_KERNEL safely. Considered that it is a API, please don't > >> introduce it. > > > > The automatic system goes a long way, but there are corner cases, for example > > work queues, which still need mem_flags. > > Could you explain why work queue need GFP_NOIO? Your fix for the memory allocation depends on it happening in the same context. If you execute code on a work queue this happens in the context of a kernel thread. > and the use case for > usbnet? Processing your response from a work queue. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists