netdev - Re: [PATCH net-next] net: tcp_memcontrol: minor: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 14 Apr 2013 15:43:32 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dborkman@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: tcp_memcontrol: minor: remove unused
 variable

From: Daniel Borkmann <dborkman@...hat.com>
Date: Sun, 14 Apr 2013 20:29:12 +0200

> Commit 10b96f7306e5 (``tcp_memcontrol: remove a redundant statement
> in tcp_destroy_cgroup()'') says ``We read the value but make no use
> of it.'', but forgot to remove the variable declaration as well. This
> was a follow-up commit of 3f1346193 (``memcg: decrement static keys
> at real destroy time'') that removed the read of variable 'val'.
> 
> This fixes therefore:
> 
>   CC      net/ipv4/tcp_memcontrol.o
> net/ipv4/tcp_memcontrol.c: In function ‘tcp_destroy_cgroup’:
> net/ipv4/tcp_memcontrol.c:67:6: warning: unused variable ‘val’ [-Wunused-variable]
> 
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>

Applied.