netdev - Re: [PATCH v3] vxlan: Allow setting destination to unicast address.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Apr 2013 21:50:44 +0900
From:	Atzm Watanabe <atzm@...atosphere.co.jp>
To:	Mike Rapoport <mike.rapoport@...ellosystems.com>
Cc:	David Stevens <dlstevens@...ibm.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	netdev-owner@...r.kernel.org,
	Stephen Hemminger <stephen@...workplumber.org>,
	Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: [PATCH v3] vxlan: Allow setting destination to unicast address.

At Tue, 16 Apr 2013 09:46:36 +0300,
Mike Rapoport wrote:
> 
> On Mon, Apr 15, 2013 at 11:53 PM, David Stevens <dlstevens@...ibm.com> wrote:
> > netdev-owner@...r.kernel.org wrote on 04/12/2013 05:09:05 AM:
> >
> >> From: Atzm Watanabe <atzm@...atosphere.co.jp>
> >
> >> Signed-off-by: Atzm Watanabe <atzm@...atosphere.co.jp>
> >> ---
> >
> > If this is turned into a vxlan_rdst, it should check for other
> > attributes to fill that-- PORT, VNI, IFINDEX-- with approprate
> > default values if not present.
> >
> > Overall, this patch looks ok to me as far as it goes, but I think
> > it'd be more useful if it were more generic; that is, if it supported
> > everything an fdb can.
> 
> I've just sent an rfc patch that is slightly more generic version of
> Atzm Watanabe work (1). It makes the "default destination" a list of
> destinations rather than a single entry.
> If the approach seems Ok, I can extend it to do "everything an fdb can".
> 
> 
> (1) http://thread.gmane.org/gmane.linux.network/265871

For more generalization, I think that "group_head" should replace
"gaddr" and related struct members, and "group_head" should allow
multicast addresses, and then multicast join/leave should be done.

I've trying to replace "gaddr" with "defaut destination" as vxlan_rdst
(but it can be set single destination yet).
I'll send the patch soon.  Could you review it?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html