netdev - Re: [net 1/2] igb: Revert support for build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Apr 2013 14:52:43 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	alexander.h.duyck@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net 1/2] igb: Revert support for build_skb in igb

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Wed, 17 Apr 2013 23:41:04 -0700

> From: Alexander Duyck <alexander.h.duyck@...el.com>
> 
> This patch actually reverts:
> igb: Support using build_skb in the case that jumbo frames are disabled
> 
> The reason for reverting this patch is that it can lead to data corruption.
> The following flow was pointed out by Ben Hutchings:
> 
> 1. skb is forwarded to another device
> 2. Packet headers are modified and it's put into a queue
> 3. Second packet is received into the other half of this page
> 4. Page cannot be reused, so is DMA-unmapped
> 5. The DMA mapping was non-coherent, so unmap copies or invalidates
> cache
> 
> The headers added in step 2 get trashed in step 5.
> 
> Reported-by: Ben Hutchings <bhutchings@...arflare.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html