netdev - Re: [PATCH] fec: Remove unneeded asm header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Apr 2013 21:56:43 +1000
From:	Greg Ungerer <gregungerer00@...il.com>
To:	Fabio Estevam <festevam@...il.com>
CC:	davem@...emloft.net, gerg@...inux.org, netdev@...r.kernel.org,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] fec: Remove unneeded asm header files

Hi Fabio,

On 18/04/13 12:18, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@...escale.com>
> 
> There is nothing in the driver that requires asm header files.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
> ---
> Greg,
> 
> I built this for ARM and x86 (tweaking Kconfig), but I don't have a m68k 
> toolchain installed here to test it.
> 
> Please build it for m68k if you have a chance. Thanks
> 
>  drivers/net/ethernet/freescale/fec_main.c |    7 -------

fec_main.c?  It doesn't exist in 3.9-rc7.
Comments and tests below based on fec.c in 3.9-rc7.


>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 719177b..22c0feb 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -50,13 +50,6 @@
>  #include <linux/pinctrl/consumer.h>
>  #include <linux/regulator/consumer.h>
>  
> -#include <asm/cacheflush.h>

There is a very bogus looking call to flush_cache_all() conditional on
CONFIG_M532x, and I suspect this won't compile if you take this out.


> -
> -#ifndef CONFIG_ARM
> -#include <asm/coldfire.h>
> -#include <asm/mcfsim.h>
> -#endif

No problem with this part. I tested on a couple of ColdFire targets with
this and they still compile ok.

Regards
Greg


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html