netdev - Re: [PATCH] tcp: call tcp_replace_ts_recent() from tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Apr 2013 13:14:41 -0400
From:	Neal Cardwell <ncardwell@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH] tcp: call tcp_replace_ts_recent() from tcp_ack()

On Fri, Apr 19, 2013 at 1:01 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Fri, 2013-04-19 at 09:59 -0700, Eric Dumazet wrote:
>> On Fri, 2013-04-19 at 12:33 -0400, Neal Cardwell wrote:
>>
>> > This patch looks good. But AFAICT the other call site for
>> > tcp_replace_ts_recent() has the same bug, which can be fixed in the
>> > same way: tcp_rcv_state_process() seems to fall through the big switch
>> > statement down to its call to tcp_replace_ts_recent() even in some
>> > cases where tcp_ack() already decided the ACK was unacceptable.
>>
>> I was not sure of the second call site, and was willing to discuss this
>> with you and Yuchung.
>>
>> Are you comfortable this is net material and not net-next ? (We are
>> talking of states other than ESTABLISHED)
>
> The other concern was about conflict with the prior net-next patch (tcp:
> remove one indentation level in tcp_rcv_state_process())

Good point. How about fixing both tcp_replace_ts_recent() call sites
in net-next, as a single patch after your  "tcp: remove one
indentation level in tcp_rcv_state_process()" net-next patch?

neal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html