netdev - Re: [PATCH 0/3] URGENT for 3.9: net: fec: revert NAPI introduction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Apr 2013 14:26:18 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	festevam@...il.com
Cc:	l.stach@...gutronix.de, netdev@...r.kernel.org,
	Frank.Li@...escale.com, shawn.guo@...aro.org
Subject: Re: [PATCH 0/3] URGENT for 3.9: net: fec: revert NAPI introduction

From: Fabio Estevam <festevam@...il.com>
Date: Fri, 19 Apr 2013 15:22:38 -0300

> Hi Lucas,
> 
> On Fri, Apr 19, 2013 at 11:36 AM, Lucas Stach <l.stach@...gutronix.de> wrote:
>> Those patches introduce instability to the point of kernel OOPSes with
>> NULL-ptr dereferences.
>>
>> The patches drop locks from the code without justifying why this would
>> be safe at all. In fact it isn't safe as now the controller restart can
>> happily free the RX and TX ring buffers while the NAPI poll function is
>> still accessing them. So with a heavily loaded but slightly instable
>> link we regularly end up with OOPSes because link change restarts
>> the FEC and bombs away buffers still in use.
> 
> Can you please let us know how to reproduce the oopses? Which SoC did
> you use in your tests?

You don't need to know this, he told you exactly and in detail what
the race is, so you should work on fixing that based solely upon his
explanation.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html